fix: fixes 422 errors in fetch_bot_summary for bots with no existing alias #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliotsegler
requested review from
statefb,
wadabee and
Yukinobu-Mine
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #651
Description of changes:
This change alters active_models to use the existing (valid) bot definition for the use case where a bot is public but doesn't have an alias. Previously this used the ActiveModelsOutput but that's the wrong type for a BotAlias signature.
I've also added some logging.
I've also covered fetch_bot_summary in unit tests - note: unlike the other tests, these are mocked and don't actually require AWS infrastructure.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.