Skip to content

Allowing passing of existing certificate #850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: v3
Choose a base branch
from

Conversation

jwfrizzell
Copy link

The following changes allow an existing certificate to be applied to an alternate domain by adding the certificate ARN to the cdk.json file.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@statefb statefb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a section on README others to explain:

  • Who need to add the certificate? What's the situation?
  • To resolve the above issue, what does the user need to do?

Copy link
Contributor

@statefb statefb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you miss passing the configration to frontend.ts from bedrock-chat.ts? Have you checked if this PR works as intended?

@statefb statefb added the needs-info Need more information such as reproduction step label May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-info Need more information such as reproduction step
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants