Allowing passing of existing certificate #850
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwfrizzell
requested review from
statefb,
wadabee and
Yukinobu-Mine
as code owners
statefb
reviewed
Apr 30, 2025
There was a problem hiding this comment.
Could you add a section on README others to explain:
- Who need to add the certificate? What's the situation?
- To resolve the above issue, what does the user need to do?
Update description for certificateArn
Remove stack comment - Expance README.md descriptiion
statefb
reviewed
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following changes allow an existing certificate to be applied to an alternate domain by adding the certificate ARN to the cdk.json file.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.