Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encryption #37

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

chaithanya77
Copy link

@chaithanya77 chaithanya77 commented Jan 21, 2022

Issue #, if available:
Description of changes:

Enabling default encryption on SNS, SQS and S3. Using AWS managed SSE, so no additional IAM changes needed. Tested the changes with a new product.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@linhlam-mp
Copy link
Contributor

linhlam-mp commented Feb 3, 2022

Hi, Can you help to share more information of end to end testing with these changes following the form below?

**End-to-end ("e2e")**: These are broad tests of overall system behavior and coherence. Please test and confirms these itemsL
    1. Verify the stack is deployed successfully.
    2. Verify URL endpoint is up and running with no error.
    3. Subscribe to the product successfully and can visit landing page with no error.
    4. Create an account using landing page.
    5. Receive notification as a Seller.
    6. Receive notification as a Buyer.
    7. Verify new user record is created in Amazon DynamoDB.

In addition, can you add more comment around why the changes are needed and if there are any trade-offs (e.g: SQS queue could not invoke lambda function from different AWS account if it is encrypted)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants