Upgraded to AWS SDK v3. #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went down the rabbit hole trying to help a customer in aws-samples/aws-marketplace-serverless-saas-integration#10. I was wrong about their problem, but you win an upgrade to AWS SDK 3, which is quite a bit nicer: no need to bring the entire SDK along and we get promises by default.
I also locked node version >= 10, otherwise you get an
Unexpected token *inasync function* paginateListAccountRoles(config, input, ...additionalArguments).By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.