Skip to content

Conversation

David-O-M
Copy link
Contributor

@David-O-M David-O-M commented Sep 16, 2025

What does this PR do?

This PR adds VeChain blockchain support to the AWS Blockchain Node Runners project, a comprehensive infrastructure-as-code solution for deploying various blockchain nodes on AWS. #213

Public Nodes (RPC): For JSON-RPC API access, supports both single and HA deployments
Authority Nodes (Validators): For network validation, single instance only

HA deployment exclusively for Public/RPC nodes with Auto Scaling Groups and Application Load Balancer
Authority nodes are intentionally restricted from HA deployment (with validation to prevent misconfiguration)

Leverages a Public snapshot system for rapid node initialization. Eliminates need for custom snapshot infrastructure. Supports both mainnet and testnet snapshots. Links can be found in the readme

Our health check and protocol for the public/rpc node run on different port so modified the ha-rpc-nodes-with-alb construct. Made it backwards compatible as well.

Motivation

The aws-blockchain-node-runners repository doesn't yet have Vechain network supported, this PR adds it.

License

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Mandatory for new node blueprints. Yes, I have added usage example to the README.md file in my blueprint folder
  • Mandatory for new node blueprints. Yes, I have implemented automated tests for all stacks in my blueprint and they pass
  • Mandatory for new node blueprints. Yes, I have added a reference to my README.md file to website/docs section for this feature
  • Yes, I have set up and ran all pre-merge quality control tools on my local machine and they don't show warnings.

For Moderators

  • The tests for all current blueprints successfully complete before merge?
  • Mandatory for new node blueprints. All pre-merge quality control tools and cdk-nag tools don't show warnings?
  • Mandatory for new node blueprints. The deployment test works on blank AWS account according to instructions in the README.md before merge?
  • Mandatory for new node blueprints. The website builds without errors?

Additional Notes

Screenshot 2025-09-16 at 18 25 18 Screenshot 2025-09-16 at 18 27 07

Can only access from within VPC
Screenshot 2025-09-16 at 18 29 45
Screenshot 2025-09-16 at 18 29 55
Screenshot 2025-09-29 at 11 49 05

Screenshot 2025-09-29 at 11 47 12

@David-O-M David-O-M force-pushed the feature/vechain branch 3 times, most recently from 9f74e56 to e434040 Compare September 29, 2025 10:44
@racket2000
Copy link
Contributor

racket2000 commented Oct 2, 2025

Hello! Thank you very much for the contribution.

The following is a minor issue I identified:

Missing CDK Nag Integration

Note: CDK Nag security checks are not running during deployments. While
suppressions exist in stack files, the AwsSolutionsChecks aspect is missing from
app.ts.

Required Changes

  1. Add CDK Nag integration to lib/vechain/app.ts:

import * as nag from "cdk-nag";

// Add at end of file:

cdk.Aspects.of(app).add(
  new nag.AwsSolutionsChecks({
      verbose: false,
      reports: true,
      logIgnores: false,
  })
);

Impact

Without CDK Nag integration, security best practices aren't being enforced
during synthesis/deployment, despite having suppressions prepared.

@racket2000 racket2000 merged commit 672e1ec into aws-samples:main Oct 6, 2025
5 checks passed
@racket2000
Copy link
Contributor

Thank you for your contribution! We appreciate the time and effort you put into this PR.

We have just merged the Vechain blueprint into the AWS Node Runners repository.

@kgapos
Copy link

kgapos commented Oct 6, 2025

Thank you @racket2000 for the review and feedback, much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants