Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allora - Pr 158 -- resolution #170

Open
wants to merge 46 commits into
base: main
Choose a base branch
from
Open

Allora - Pr 158 -- resolution #170

wants to merge 46 commits into from

Conversation

racket2000
Copy link
Contributor

@racket2000 racket2000 commented Feb 12, 2025 •
edited
Loading

What does this PR do?

🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.

Motivation

I am submitting this PR to incorporate changes to resolve issues on Allora's original PR.

License

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Mandatory for new node blueprints. Yes, I have added usage example to the README.md file in my blueprint folder
  • Mandatory for new node blueprints. Yes, I have implemented automated tests for all stacks in my blueprint and they pass
  • Mandatory for new node blueprints. Yes, I have added a reference to my README.md file to website/docs section for this feature
  • Yes, I have set up and ran all pre-merge quality control tools on my local machine and they don't show warnings.

For Moderators

  • The tests for all current blueprints successfully complete before merge?
  • Mandatory for new node blueprints. All pre-merge quality control tools and cdk-nag tools don't show warnings?
  • Mandatory for new node blueprints. The deployment test works on blank AWS account according to instructions in the README.md before merge?
  • Mandatory for new node blueprints. The website builds without errors?

Additional Notes

allora-rc and others added 30 commits June 27, 2024 13:40
@allora-rc
Create README.md
86fb2ae 
Signed-off-by: allora-rc <[email protected]>
@allora-rc
Create file.txt
b583d83 
Signed-off-by: allora-rc <[email protected]>
@allora-rc
Add files via upload
4147ed6 
Signed-off-by: allora-rc <[email protected]>
@allora-rc
Update README.md
662bcd9 
Signed-off-by: allora-rc <[email protected]>
@Madisonw
working
9cc8fc4
@Madisonw
allora stack
dc6637d
@Madisonw
update readme
dd686fd
@Madisonw
added tests, redid project structure, added .env sample, deleted file…
37f914c 
….txt, removed dependencies from package.json, removed package-lock.json, parameterized numerous values
@Madisonw
adding drawing source and fixing scripts to with in c9
9845ecc
@Madisonw
user-data script
abc4db3
@Madisonw
adding types: [ node ] to tsconfig, and uploading the node.sh script …
85042cb 
…to an s3 bucket and getting it executed as user data
@Madisonw
success msg
a868467
@Madisonw
adding allora.md to website
ff3c3c3
@Madisonw
using singlenodeconstruct
8415f6b
@Madisonw
added: cdk-nag, changed @type source, removed package-lock, using Sin…
9853f57 
…gleNodeConstruct, added a cloudwatch dashboard, tests for CloudWatch added
@Madisonw
instance role and fixing issue with EIP
9dce197
@Madisonw
user-data still freezing the instance
c221022
@Madisonw
installing pip differently
569cf95
@Madisonw
user-data script
e37c868
@Madisonw
venv approach
71423d8
@Madisonw
using amazon AMI
0771b73
@Madisonw
no package-lock
174635c
@Madisonw
restore package-lock
f73dd0d
@Madisonw
updating the readme, and the draw png/source
e36c476
@Madisonw
adding allocmd to user-data
85c2976
@Madisonw
adding allocmd generate command and parameterization
e263525
@Madisonw
test env file
00d0180
@Madisonw
updating readme with FAQ
3421a2d
@Madisonw
undeploy common cleanup step
ce0dfd6
@Madisonw
typo on stack name
7a4bf05
@racket2000 racket2000 changed the base branch from allora to main February 12, 2025 18:47
@racket2000 racket2000 marked this pull request as draft February 12, 2025 18:53
@racket2000 racket2000 marked this pull request as ready for review February 12, 2025 18:53
@racket2000 racket2000 closed this Feb 12, 2025
@racket2000 racket2000 reopened this Feb 12, 2025
github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 14, 2025
View reviewed changes
lib/allora/lib/assets/user-data-alinux.sh
su bcuser

echo "Install allorad"
curl -sSL https://raw.githubusercontent.com/allora-network/allora-chain/main/install.sh | bash -s -- v0.8.0

Check warning

Code scanning / Semgrep OSS

Semgrep Finding: bash.curl.security.curl-pipe-bash.curl-pipe-bash Warning

Data is being piped into bash from a curl command. An attacker with control of the server in the curl command could inject malicious code into the pipe, resulting in a system compromise. Avoid piping untrusted data into bash or any other shell if you can. If you must do this, consider checking the SHA sum of the content returned by the server to verify its integrity.
@github-actions GitHub Actions
Copy link
Contributor

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@racket2000 @allora-rc @Madisonw @frbrkoala @vlasonfa