Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Lab 4 - 'Advance RAG' notebook (4) existing bugs. #48

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

avelizf
Copy link

@avelizf avelizf commented Nov 15, 2024

Fixes include (1) update regions to us-west-2, (2) remove 'a_opensearch_utilities_' library, (3) added 'openpyxl', (4) Remove legacy client.count_tokens() call from Anthropic.

Issue #, if available:
Several issues raised during execution,

  • Regions not matching available one when running workshop
  • a_opensearch_utilities_ library no longer needed raising blocking run
  • openpyxl library pending to be installed
  • Anthropic legacy client.count_tokens() is no longer available
  • Needed extra Sagemaker Role policies for OpenSearch Serverless policies and collection creation (done in workshop cdk)

Description of changes:

  • Updated regions in notebook
  • Removed a_opensearch_utilities_ library import
  • Added openpyxl pip install at the begining
  • Removed client.count_tokens() code
  • Updated workshop CDK to include 2 extra needed aoss role policies

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

…st-2, (2) remove 'a_opensearch_utilities_' library, (3) added 'openpyxl', (4) Remove legacy client.count_tokens() call from Anthropic.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant