Skip to content

Conversation

MichaelWalker-git
Copy link
Contributor

Summary

This PR introduces two main updates to the project:

  1. CDK Version Update and Deprecated Method Replacement:

    • Upgraded AWS CDK to version 2.164.1 to stay current and access new features and improvements.
    • Updated deprecated methods across various files to ensure compatibility with the latest CDK version, reducing technical debt and future-proofing the codebase.
  2. Dynamic Partition Key for GovCloud Support:

    • Added dynamic partitioning to accommodate different AWS partitions (aws, aws-us-gov, etc.), making the code compatible with both commercial and GovCloud regions.
    • Leveraged Aws.PARTITION in ARN definitions to automatically adjust the partition prefix based on the environment, ensuring accurate ARN generation for S3, WorkMail, and other AWS services.

Changes

  • Refactored ARN definitions to dynamically pull Aws.PARTITION where required.
  • Updated policies and lambda environment variables to support both GovCloud and standard AWS regions.
  • Made minor optimizations in variable declarations, converting var to const to enhance readability and prevent variable mutation.

Impact

  • The updates ensure smoother deployments and executions in GovCloud environments while maintaining backward compatibility.
  • The transition to dynamic partitioning enables this stack to be deployed across AWS commercial and GovCloud regions, providing broader support and flexibility.

Testing

  • Integration tests were run to verify the correct ARN generation in GovCloud and commercial AWS environments.
  • Policy checks were validated to ensure the appropriate permissions were granted dynamically based on region-specific requirements.

This PR addresses multi-region compatibility concerns and enhances the project's adaptability with the latest AWS CDK standards.

@MichaelWalker-git MichaelWalker-git changed the title Feat/add dynamic partition feat(): add dynamic partition Oct 30, 2024
@MichaelWalker-git MichaelWalker-git changed the title feat(): add dynamic partition feat: add dynamic partition Oct 30, 2024
@MichaelWalker-git MichaelWalker-git self-assigned this Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant