Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add react build for KVSBrowserIngestion App #398

Merged
merged 3 commits into from
Jan 9, 2025

Conversation

sirknightj
Copy link
Contributor

@sirknightj sirknightj commented Jan 8, 2025

Issue #, if available:

Description of changes:

  • Add a react build for this react application.

  • This ensures that the builds don't get broken due to a dependency update by dependabot.

  • Also resolve a build issue from a previous dependabot update due to non-backwards compatible change by webpack:

ERROR in ./node_modules/aws4/aws4.js 2:10-24
Module not found: Error: Can't resolve 'url' in '/home/runner/work/amazon-kinesis-video-streams-demos/amazon-kinesis-video-streams-demos/producer-js/browser-based-ingestion/node_modules/aws4'
BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default.
This is no longer the case. Verify if you need this module and configure a polyfill for it.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sirknightj sirknightj added the ci label Jan 8, 2025
@sirknightj sirknightj force-pushed the producer-js-browser-based-ingestion-ci branch from 0c6440b to 111548e Compare January 9, 2025 01:17
@sirknightj sirknightj merged commit e32f61a into master Jan 9, 2025
2 checks passed
@sirknightj sirknightj deleted the producer-js-browser-based-ingestion-ci branch January 9, 2025 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants