Skip to content

Conversation

rgzoso
Copy link

@rgzoso rgzoso commented Jun 20, 2024

Issue #, if available:

Description of changes:

  • Use of data lookup for partition so this is usable for gov-cloud
  • Logic to use a Entra ID (AzureAD) Service Principal short-term token instead of PAT
  • Updated permission logic to work with ecs task definition revisions
  • GovCloud CodePipeline requires the project_visibility directive
  • AWS ECS doesnt honor Dockerfile health check. Updated to work with ECS Task Definition.
  • terraform.tfvars: ado_org needs to be the Org Name not the ID. Wording was confusing.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

add logic for Service Principal instead of PAT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants