Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ip-detector ipv6 support #32

Merged
merged 1 commit into from
Jun 12, 2024
Merged

feat: ip-detector ipv6 support #32

merged 1 commit into from
Jun 12, 2024

Conversation

hancin
Copy link
Member

@hancin hancin commented May 20, 2024

Issue #, if available:

Description of changes:

  • Add configuration parameters to IP Detector to return IPv6 addresses if required
  • Set the default to return only IPv4 addresses (the current behavior), to avoid customer impact and require opt-in to the new behavior.
  • Added unit tests to validate the changes.
  • Updated existing unit tests as required

Why is this change necessary:

  • IoT devices are more and more likely to use IPv6 and hybrid environments, and we should support this use case.

How was this change tested:

  • Unit Tests were written to confirm the functionality.
  • As discussed in design meeting, user acceptance test and suitable IPv6 environment work is in progress to perform end-to-end testing.

Any additional information or context required to review the change:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@hancin hancin changed the title feat. IP Detector IPv6 support feat: IP Detector IPv6 support May 20, 2024
@hancin hancin changed the title feat: IP Detector IPv6 support feat: ip-detector ipv6 support May 20, 2024
@hancin hancin marked this pull request as draft May 20, 2024 17:30
jcosentino11
jcosentino11 previously approved these changes May 20, 2024
Copy link

github-actions bot commented May 20, 2024

Unit Tests Coverage Report

File Coverage Lines Branches
All files 78% 81% 76%

Minimum allowed coverage is 60%

Generated by 🐒 cobertura-action against 43c0e04

@hancin hancin marked this pull request as ready for review June 11, 2024 20:35
@jcosentino11 jcosentino11 merged commit 3b14889 into main Jun 12, 2024
3 checks passed
@jcosentino11 jcosentino11 deleted the ipv6-support branch June 12, 2024 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants