Skip to content

refactor: convert runtime tests from external to internal package tests #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: convert runtime tests from external to internal package tests #202

wants to merge 1 commit into from
+31 −38

Conversation

a-hilaly
Copy link
Member

Change test files from runtime_test to runtime package to enable
testing of package private functions. Remove ackrt import alias
as tests now have direct access to runtime package symbols.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@a-hilaly
refactor: convert runtime tests from external to internal package tests
7624d0d 
Change test files from `runtime_test` to `runtime` package to enable
testing of package private functions. Remove ackrt import alias
as tests now have direct access to runtime package symbols.
@ack-prow ack-prow bot requested review from jlbutler and knottnt September 23, 2025 03:14
@ack-prow ack-prow bot added the approved label Sep 23, 2025
@a-hilaly
Copy link
Member Author

/retest

1 similar comment
@a-hilaly
Copy link
Member Author

/retest

michaelhtm
michaelhtm approved these changes Sep 23, 2025
View reviewed changes
Copy link
Member

@michaelhtm michaelhtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2025
@ack-prow ACK Prow
Copy link

ack-prow bot commented Sep 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, michaelhtm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [a-hilaly,michaelhtm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michaelhtm
Copy link
Member

/test ec2-controller-test

@a-hilaly
Copy link
Member Author

/retest

@michaelhtm
Copy link
Member

/test ec2-controller-test

@a-hilaly
Copy link
Member Author

/retest

1 similar comment
@michaelhtm
Copy link
Member

/retest

@michaelhtm
Copy link
Member

/test ec2-controller-test

@ack-prow ACK Prow
Copy link

ack-prow bot commented Sep 24, 2025

@a-hilaly: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
verify-attribution 7624d0d link false /test verify-attribution
ec2-controller-test 7624d0d link true /test ec2-controller-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelhtm michaelhtm michaelhtm approved these changes

@jlbutler jlbutler Awaiting requested review from jlbutler

@knottnt knottnt Awaiting requested review from knottnt

Assignees

@michaelhtm michaelhtm

Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@a-hilaly @michaelhtm