feat(react): reenable react 19 support #6296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: de4d269 The changes in this PR will be included in the next version bump. This PR includes changesets to release 15 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
calebpollman
force-pushed
the
react/reenable-react-19
branch
from
33ca349 to
a2f998a
Compare
calebpollman
temporarily deployed
to
deployment
GitHub Actions
Inactive
jordanvn
reviewed
Jan 14, 2025
docs/src/pages/[platform]/connected-components/storage/fileuploader/react.mdx
Show resolved
Hide resolved
jordanvn
reviewed
Jan 14, 2025
jordanvn
reviewed
Jan 14, 2025
calebpollman
changed the title
jordanvn
previously approved these changes
Jan 14, 2025
calebpollman
changed the title
jordanvn
previously approved these changes
Jan 14, 2025
calebpollman
commented
Jan 14, 2025
jordanvn
approved these changes
Jan 14, 2025
dbanksdesign
approved these changes
Jan 14, 2025
Merged
4 tasks
jjarvisp
added a commit
that referenced
this pull request
Jan 28, 2025
* chore(react): remove direct usage of react-test-renderer and types (#6255) * chore(deps): upgrade next deps to point to ^14.2.15 (#6263) * fix(docs): use correct listLocation attribute names in Storage Browser auth example (#6264) * chore(react-native): update allowed peerDep to >=0.70 (#6266) * chore(react): add support for react 19 (#5826) * chore(storage-browser): bump up package size limit (#6267) * chore(changeset): update react 19 changeset from patch to minor bump (#6269) * chore(react): remove radix-ui upgrades (#6268) * fix(docs): remove typo from liveness detector core docs (#6256) * Version Packages (#6261) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * chore: remove temporary pin to react 18 in react@latest build tests (#6274) * chore: remove temporary use of react 18 in react@latest build tests * chore: update workflow for forced test run * chore: adjusting testing strategy, modify publish workflow instead of reusable test * chore: reverting temporary testing changes * Revert support for React 19 (#6278) * Revert "chore: remove temporary pin to react 18 in react@latest build tests (#6274)" This reverts commit d9ee32d. * Revert "fix(docs): remove typo from liveness detector core docs (#6256)" This reverts commit 9d71dd8. * Revert "chore(react): remove radix-ui upgrades (#6268)" This reverts commit c623990. * Revert "chore(changeset): update react 19 changeset from patch to minor bump (#6269)" This reverts commit 7045aed. * Revert "chore(storage-browser): bump up package size limit (#6267)" This reverts commit a79b8e9. * Revert "chore(react): add support for react 19 (#5826)" This reverts commit 954e9be. * chore: add changeset * Version Packages (#6281) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * chore(deps): bump nextjs version (#6284) * chore: add v0.76 and latest to React Native build system tests (#6285) * chore: add react native v0.76 build system tests to CI * chore: add react native 'latest' to build system tests * fix(github-actions): bump upload-artifact to v4 (#6289) * feat(i18n): add Chinese translations for password fields in zh.ts (#6125) Co-authored-by: Caleb Pollman <[email protected]> * test(e2e): add storage-browser offline tests (#6206) * test(e2e): add storage-browser offline tests * address feedback * fix EOF * fix EOF * Update packages/e2e/cypress/integration/common/shared.ts Co-authored-by: Caleb Pollman <[email protected]> * address feedback --------- Co-authored-by: Caleb Pollman <[email protected]> * chore(docs): update react web Authenticator hideSignUp example (#6290) * feat(react): reenable react 19 support (#6296) * Revert "Revert support for React 19 (#6278)" This reverts commit 475e4a3. * update radix deps * remove radix namespace sanitization * migrate/cleanup FileUploader component override example * add ExtendedView component for surfacing ReactNode conflicts * Remove extended and overridden react types * chore(build-system-tests): disable react@latest tests (#6297) * Version Packages (#6292) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * chore(ci): add retry delays to build tests & upgrade actions/cache (#6291) * chore: add delay between install retries, swap RN to use install script * chore: upgrade actions/cache to v4.2.0 * chore(build-system-tests): reenable react@latest tests (#6299) * fix(slider): remounted controlled value not updating (#6301) * fix(ui): fix and add missing sv translations (#6288) Co-authored-by: Jordan Van Ness <[email protected]> Co-authored-by: Caleb Pollman <[email protected]> * chore(changeset): add changeset for PR #6301 (#6303) * fix(react-storage): enable default checksum algorithm for create folder action (#6305) * fix: include default checksum alg header in createFolder action * test: update createFolder test spec for checksum alg header * chore: adding changeset * Version Packages (#6304) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * chore(docs): Update Android UI component versions (#6311) * chore(deps-dev): bump vite from 5.2.14 to 5.4.12 (#6307) Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 5.2.14 to 5.4.12. - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/v5.4.12/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v5.4.12/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(storage-browser): export UseView type (#6314) * chore(ui-react-storage): clean up outdated styles file (#6197) Co-authored-by: ashika112 <[email protected]> * chore(react-native): add fed sign in example env (#6318) --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Caleb Pollman <[email protected]> Co-authored-by: Tiffany Yeung <[email protected]> Co-authored-by: Jordan Van Ness <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: BeforeSunset16 <[email protected]> Co-authored-by: Caleb Pollman <[email protected]> Co-authored-by: Ashwin Kumar <[email protected]> Co-authored-by: Danny Banks <[email protected]> Co-authored-by: berg-dee <[email protected]> Co-authored-by: Vincent Tran <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: AllanZhengYP <[email protected]> Co-authored-by: ashika112 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Re-enables support for
react@19, see (#5826) for the bulk of updatesAdditional Updates Applied
update
ForwardRefPrimitiveinterface to directly extend fromReact.ForwardRefExoticComponentand remove hand rolledJSXElementForwardRefExoticComponent, replace overload function typing return withReturnType<React.ForwardRefExoticComponent>to allow for return type to be derived from consuming project's installed@types/reactversion, add deprecation flag (ref). To be noted, this change does update the shape ofForwardRefPrimitivein regards to its return type,defaultPropsandpropTypesbut is considered to be a bug fix as the previous handling incorrectly applied those types in projects consuming@types/react@18and does not impact runtime behaviorupdate
Primitiveinterface to extend directly fromReact.ForwardRefRenderFunction, remove hand rolledJSElementForwardRefRenderFunction, add deprecation flag (ref)update
@radix-uidirect deps to remove additional installation of@types/[email protected]via[email protected]transitive dep@radix-ui/[email protected]->@radix-ui/react-direction@^1.1.0@radix-ui/[email protected]->@radix-ui/react-dropdown-menu@^2.1.0@radix-ui/[email protected]->@radix-ui/react-slider@^1.2.0remove usage of and add deprecation flag usage to
sanitizeNamespaceImportutil previously used for monkey patching ESM support for@radix-ui/*@1.0.0direct deps (new versions are ESM compatible by default)add extended
Viewprimitive in build system test to ensure that conflicting@react/typesfail the tests (ref)fix typing and migrate static .mdx component override example from the docs to an example to ensure type checking of example code (old, new)
Issue #, if available
resolves #6084
resolves #6275
Description of how you validated changes
yarn lint && yarn build@aws-amplify/[email protected]to Amplify Hosting (source)@aws-amplify/[email protected], usage of extended types to ensure correct extension of installed@react/typesversion,npm run dev,npm run build, andnpm ls reactreact@16+vite: https://github.com/calebpollman/react-19-smoke-tests/tree/main/react-16react@17+vite: https://github.com/calebpollman/react-19-smoke-tests/tree/main/react-17react@18+vite: https://github.com/calebpollman/react-19-smoke-tests/tree/main/react-18react@19+vite: https://github.com/calebpollman/react-19-smoke-tests/tree/main/react-19next@12: https://github.com/calebpollman/react-19-smoke-tests/tree/main/next-12next@15: https://github.com/calebpollman/react-19-smoke-tests/tree/main/next-15Checklist
yarn testpasses and tests are updated/addeddocs,e2e,examples, or other private packages.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.