Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(liveness): Prevent the "Create Liveness Session" button from flashing on screen transition #193

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

vincetran
Copy link
Member

Issue #, if available:
N/A

Description of changes:
Because the fetchingSession.value gets set to false on session retrieval, it has a side effect of showing the "Create Liveness Session" button for a split second before the screen transitions to the LivenessScreen. By only resetting it on exception, we can prevent that flashing from occurring.

How did you test these changes?
Manually, the button no longer flashes and no regression on exception.

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Ensure commit message has the appropriate scope (e.g fix(liveness): message, fix(authenticator): message, fix(all): message)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@vincetran vincetran requested review from a team as code owners September 24, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant