fix(adapter-nextjs): secure: false is not set for localhost on sign-in #14231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashika112
reviewed
Feb 20, 2025
| ) => ({ | ||
| domain: setCookieOptions?.domain, | ||
| path: '/', | ||
| httpOnly: true, | ||
| secure: overrides?.secure ?? true, | ||
| secure: isSSLOrigin(origin), |
There was a problem hiding this comment.
curious: why were these overrides to begin with?
jjarvisp
reviewed
Feb 20, 2025
jjarvisp
approved these changes
Feb 21, 2025
ashika112
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
securecookie attribute value calculation into the functions that actually generate the cookie attributes to prevent missesIssue #, if available
Description of how you validated changes
Checklist
yarn testpassesChecklist for repo maintainers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.