Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth): associate unAuth identityId to newly authenticated user's identityId #14207

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Samaritan1011001
Copy link
Member

@Samaritan1011001 Samaritan1011001 commented Feb 12, 2025

Description of changes

Currently, we create and maintain separate identityIds for unAuth (guest) user and newly authenticated user. With this change, we will "upgrade" the unAuth user's identityId to the new authenticated user.

Issue #, if available

#14197

Description of how you validated changes

Action Expected identityId
fetchAuthSession BEFORE signIn ID1
fetchAuthSession AFTER signUp NEW user U1 ID1
fetchAuthSession AFTER signIn NEW user U1 ID1 (linked login)
fetchAuthSession AFTER signOut ID2
fetchAuthSession AFTER signIn EXISTING user U1 ID1
fetchAuthSession AFTER 2nd singOut ID3
fetchAuthSession AFTER signUp NEW user U2 ID3
fetchAuthSession AFTER signIn NEW user U2 ID3 (linked login)
fetchAuthSession AFTER signIn EXISTING user U1 ID1
fetchAuthSession BEFORE signIn & AFTER signOut ID4 → ID5

Checklist

  • PR description included
  • yarn test passes
  • Unit Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

Checklist for repo maintainers

  • Verify E2E tests for existing workflows are working as expected or add E2E tests for newly added workflows
  • New source file paths included in this PR have been added to CODEOWNERS, if appropriate

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@thesnups
Copy link

Thank you for working on this!

@Samaritan1011001 Samaritan1011001 changed the title fix(auth): associate unAuth identityId to auth identityId fix(auth): associate unAuth identityId to newly authenticated user's identityId Feb 14, 2025
@Samaritan1011001 Samaritan1011001 marked this pull request as ready for review February 20, 2025 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants