fix: resolve security alerts for GITHUB_TOKEN permissions and upgrade dependencies#48
Merged
Conversation
- Add an empty `permissions: {}` block to the package workflow to restrict the default `GITHUB_TOKEN` to zero permissions
- The workflow authenticates entirely via a GitHub App token (added in #43), so `GITHUB_TOKEN` is unused and should be locked down
- Resolves code scanning alert #2 (actions/missing-workflow-permissions)
…ble transitive dependencies
- Update `fast-xml-parser` override from `5.3.6` to `>=5.3.8` to patch a stack overflow
in XMLBuilder with `preserveOrder: true` (resolves Dependabot alert #7). The AWS SDK's
`@aws-sdk/xml-builder` still pins `fast-xml-parser` to `5.3.6` upstream, so the override
remains necessary.
- Update `undici` override from `6.23.0` to `>=6.23.0` so future patches are picked up
automatically.
dhahm-amazon
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
permissions: {}to the package workflow to lock down the unusedGITHUB_TOKEN. The workflow authenticates entirely via a GitHub App token , soGITHUB_TOKENneeds zero permissions.fast-xml-parseroverride from5.3.6to>=5.3.8to patch a stack overflowin XMLBuilder with
preserveOrder: true.undicioverride from6.23.0to>=6.23.0so future patches are picked upautomatically.