Repository navigation
feat: make the egress firewall optional - #7
Merged
Merged
Conversation
Add an enable_firewall copier question (default true, preserving current behaviour). When disabled, the template omits the firewall entirely: - init-firewall.sh and extra-allowed-domains are not rendered (conditional filenames) - the Dockerfile skips the iptables/ipset tooling, the firewall script COPY, and the sudoers entry - devcontainer.json drops the NET_ADMIN/NET_RAW capabilities - startup.sh no longer invokes the firewall (now templated as .jinja) Tests cover both the enabled-by-default and disabled paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an enable_firewall copier question (default true, preserving current behaviour). When disabled, the template omits the firewall entirely:
Tests cover both the enabled-by-default and disabled paths.