Repository navigation
refactor: make extra-allowed-domains a visible file - #3
Merged
Merged
Conversation
Rename .extra-allowed-domains -> extra-allowed-domains so it's not hidden by default ls, doesn't get swept up in dotfile-broad gitignore patterns, and is more obviously user-editable config (matching the visible naming of devcontainer.env). Touches the firewall script's hardcoded read path, README references, the test fixture path, and drops the now-stale _skip_if_exists entry for the old name (3-way merge is the right semantics for this file anyway, since auto-injected per-tool domains should update on copier update).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename .extra-allowed-domains -> extra-allowed-domains so it's not hidden by default ls, doesn't get swept up in dotfile-broad gitignore patterns, and is more obviously user-editable config (matching the visible naming of devcontainer.env).
Touches the firewall script's hardcoded read path, README references, the test fixture path, and drops the now-stale _skip_if_exists entry for the old name (3-way merge is the right semantics for this file anyway, since auto-injected per-tool domains should update on copier update).