[FIX] hr_employee_catch_partner: When the partner of a employee was c…#11
Open
mikelarre wants to merge 3 commits intoavanzosc:8.0from
Open
[FIX] hr_employee_catch_partner: When the partner of a employee was c…#11mikelarre wants to merge 3 commits intoavanzosc:8.0from
mikelarre wants to merge 3 commits intoavanzosc:8.0from
Conversation
oihane
reviewed
Oct 18, 2017
| other_employee = self.search( | ||
| [('address_home_id', '=', self.address_home_id.id), | ||
| ('id', '!=', self.id)], limit=1) | ||
| self.address_home_id.employee_id = other_employee or False |
Contributor
There was a problem hiding this comment.
Habría que tener en cuenta cuando no hay previamente "self.address_home_id" que es lo que realmente está fallando
oihane
reviewed
Oct 18, 2017
| @api.multi | ||
| def write(self, vals): | ||
| result = super(HrEmployee, self).write(vals) | ||
| if vals.get('address_home_id', False): |
Contributor
There was a problem hiding this comment.
De esta manera cuando "quitas" el address_home_id del empleado no está eliminando el empleado del partner
…hanged the old one did not change the pointing to this employee, creating issues on contract assignations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…hanged the old one did not change the pointing to this employee, creating issues on contract assignations