Skip to content

Fix Helidon path openapi generation #596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

SentryMan
Copy link
Collaborator

Resolves #595

@SentryMan SentryMan added the bug Something isn't working label Apr 24, 2025
@SentryMan SentryMan added this to the 3.3 milestone Apr 24, 2025
@SentryMan SentryMan requested a review from rbygrave April 24, 2025 18:13
@SentryMan SentryMan self-assigned this Apr 24, 2025
@@ -108,9 +111,6 @@ private void writeRoutes(List<ControllerMethodWriter> methods) {

for (final ControllerMethodWriter methodWriter : methods) {
methodWriter.writeRule();
if (!reader.isDocHidden()) {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the problem was that it was setting the openApi information before the parameter was determined to be a path

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Path parameters are being output to the openapi.json as query params
1 participant