chore(all): use upstream protocol params #1563
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alarso16
approved these changes
Apr 16, 2025
ceyonur
reviewed
Apr 17, 2025
| const ( | ||
| GasLimitBoundDivisor uint64 = 1024 // The bound divisor of the gas limit, used in update calculations. | ||
| MaxGasLimit uint64 = 0x7fffffffffffffff // Maximum the gas limit (2^63-1). | ||
| MaximumExtraDataSize uint64 = 64 // Maximum size extra data may be after Genesis. |
There was a problem hiding this comment.
I think this is the only params changed from upstream right? Let's keep those changed constants here so we know what's changed.
There was a problem hiding this comment.
I moved MaximumExtraDataSize to plugin/evm/header/extra.go as an unexported constant, given it's the only place where it's used. I think it's fine as it is? The other params are the same as upstream
qdm12
commented
Apr 18, 2025
| const ( | ||
| GasLimitBoundDivisor uint64 = 1024 // The bound divisor of the gas limit, used in update calculations. | ||
| MaxGasLimit uint64 = 0x7fffffffffffffff // Maximum the gas limit (2^63-1). | ||
| MaximumExtraDataSize uint64 = 64 // Maximum size extra data may be after Genesis. |
There was a problem hiding this comment.
I moved MaximumExtraDataSize to plugin/evm/header/extra.go as an unexported constant, given it's the only place where it's used. I think it's fine as it is? The other params are the same as upstream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Move protocol params code from subnet-evm to libevm since it's the same.
Initially proposed in #1552
How this works
MaximumExtraDataSizewhich is modified in coreth) and delete params/protocol_params.go and params/extras/protcol_params.go.TestUpstreamParamsValuesis a change detector test to detect a geth params change in a future upgrade to make sure we take it into account.How this was tested
Existing CI passing
Need to be documented?
No
Need to update RELEASES.md?
No