feat: vm.Hooks.PreprocessingGasCharge()
#235
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
In lieu of modifications to
core.IntrinsicGas()
, required for support of Warp in SAE. It's impossible to guarantee that the necessary options would always be passed toIntrinsicGas()
if introduced, and the tx itself isn't available to the function so a hook is also a non-solution.How this works
vm.Hooks
are extended to includePreprocessingGasCharge(tx common.Hash) (uint64, error)
, which returns the amount of gas to be charged betweencore.IntrinsicGas
andvm.EVM
execution charges. The two entry points to execution,vm.EVM.Call()
andvm.EVM.Create()
are modified to first spend said charge before running upstream logic.The new hook is defined on a separate interface definition, embedded in
vm.Hooks
, to allow types to implement just that method and enforce it with thevar _ vm.Preprocessor = (*impl)(nil)
pattern.How this was tested
Integration tests via both
core.ApplyTransaction()
andcore.ApplyMessage()
. The former is more comprehensive, while the latter allows for inspection of interim error values.