Remove unused struct #1027
Merged
Remove unused struct #1027
+0
−164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoff-vball
requested review from
batconjurer,
bernard-avalabs,
iansuvak,
mdelle1,
michaelkaplan13 and
ylg-avalabs
iansuvak
reviewed
Nov 18, 2025
vms/evm/subscriber_test.go
Outdated
| } | ||
|
|
||
| // nolint: unused | ||
| // Used to create a valid unsigned message for testing. Should not be used directly in tests. |
Contributor
There was a problem hiding this comment.
I see that this got moved from contract_message-test.go. but I don't think the comment here is sufficient -- if it's to be used for testing but should not be used directly in tests we should explain where and how it should be used.
Contributor
Author
There was a problem hiding this comment.
I just chose to remove it. I think it was useful in earlier stages of warp testing, but no longer necessary.
iansuvak
approved these changes
Nov 18, 2025
iansuvak
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Removes unused
ContractMessagestruct.How this works
How this was tested
How is this documented