Graft #1001
Draft
Graft #1001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N-03 Missing Getter Functions
N-10 Potential Storage Collision
L-01 Validators May Not Be Able to Exit Due to Churn Limits
N-11 Inconsistent Usage of Interfaces
images updated from subnet to L1
Update formatting to conform to solhint 5.1.0
M-02 Clarify selection of PoA weights
M-01 Limit churn period to 24 hours
Update go
Bumps [golang.org/x/tools](https://github.com/golang/tools) from 0.32.0 to 0.33.0. - [Release notes](https://github.com/golang/tools/releases) - [Commits](golang/tools@v0.32.0...v0.33.0) --- updated-dependencies: - dependency-name: golang.org/x/tools dependency-version: 0.33.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
…g/x/tools-0.33.0 Bump golang.org/x/tools from 0.32.0 to 0.33.0
…methods to initiate[Validator/Delegator]Registration
Move rewardRecipient fields from removal to registration methods
Remove subnet-evm submodule
Update to tagged rcs
Bumps [golang.org/x/tools](https://github.com/golang/tools) from 0.37.0 to 0.38.0. - [Release notes](https://github.com/golang/tools/releases) - [Commits](golang/tools@v0.37.0...v0.38.0) --- updated-dependencies: - dependency-name: golang.org/x/tools dependency-version: 0.38.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
…g/x/tools-0.38.0 Bump golang.org/x/tools from 0.37.0 to 0.38.0
Bumps google.golang.org/protobuf from 1.36.9 to 1.36.10. --- updated-dependencies: - dependency-name: google.golang.org/protobuf dependency-version: 1.36.10 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
…lang.org/protobuf-1.36.10 Bump google.golang.org/protobuf from 1.36.9 to 1.36.10
Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.25.3 to 2.27.2. - [Release notes](https://github.com/onsi/ginkgo/releases) - [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md) - [Commits](onsi/ginkgo@v2.25.3...v2.27.2) --- updated-dependencies: - dependency-name: github.com/onsi/ginkgo/v2 dependency-version: 2.27.2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
…m/onsi/ginkgo/v2-2.27.2 Bump github.com/onsi/ginkgo/v2 from 2.25.3 to 2.27.2
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Slither found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
There was a problem hiding this comment.
Semgrep PRO found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
How this works
icm-contractswhich moves all the files into a sub-directory calledicm-contracts(we could use a different name). This is so the repo is entirely contained when grafting it over. Otherwise all the top level files conflict and it's a mess.go.mod,.gitgitnore, etc) are consolidated..githubfolders are consolidated. I consolidated all linting type workflows into one file.scriptsfolders are consolidated. E2E tests foricm-contractsrenamed tocontracts_e2e_test.shicm-servicesin consolidated with all the other contractsicm-servicesgo.moddependency onicm-servicesremoved.TODOs
READMEto reflect new repo structure.libto top level.icm-contractsdependency onicm-servicescommit (just use the code in the repo).CONTRIBUTING.mdHow this was tested
Existing CI
How is this documented
TODO