Bump up avalanchgo and subnet-evm version #849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ylg-avalabs
requested review from
bernard-avalabs,
geoff-vball,
iansuvak,
mdelle1 and
michaelkaplan13
geoff-vball
approved these changes
Oct 2, 2025
iansuvak
approved these changes
Oct 2, 2025
iansuvak
reviewed
Oct 3, 2025
|
|
||
| fmt.Println("flagVars.ActivateGranite()", flagVars.ActivateGranite()) | ||
| upgrades := upgrade.Default | ||
| if flagVars.ActivateGranite() { |
There was a problem hiding this comment.
So what I think you actually want to do here is modify the flagvars themselves to return ActivateGranite before passing it into the newTmpnetNetwork. Checking it here won't do anything for the processes that the tmpnet spins up
There was a problem hiding this comment.
The we set the upgrade in the network.DefaultFlags. Then, we passed the network in to e2e.NewTestEnvironment. I think upgrade would be set when we create test env but I looked into the code and not sure how this work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
How this works
How this was tested
How is this documented