Ensure golang input is up-to-date for nix flake #1382
Conversation
The PR introducing the nix flake missed ensuring that the golang input from avalanchego reflected the update for 1.24.9. This change remedies that oversight and ensures that CI will catch it in the future.
maru-ava
requested review from
aaronbuchwald,
alarso16,
demosdemon and
rkuris
as code owners
maru-ava
force-pushed
the
maru/fix-flake
branch
from
2f1a132 to
999bb83
Compare
| - uses: actions/checkout@v4 | ||
| - uses: DeterminateSystems/nix-installer-action@786fff0690178f1234e4e1fe9b536e94f5433196 #v20 | ||
| - uses: DeterminateSystems/magic-nix-cache-action@565684385bcd71bad329742eefe8d12f2e765b39 #v13 | ||
| - name: Check golang flake input is up to date |
There was a problem hiding this comment.
The just PR simplifies local usage.
| - name: Check golang flake input is up to date | ||
| working-directory: ffi | ||
| run: | | ||
| nix flake update golang |
There was a problem hiding this comment.
Does this command update golang to the latest version? If so, that isn't what we want -- we want to be in sync with coreth.
There was a problem hiding this comment.
I'd like to figure this out myself but I couldn't figure out where to find the source or steps that this actually performs. Can you point me to those as well?
There was a problem hiding this comment.
This ensures that the lockfile is consistent with the version of the golang flake input.
Maybe it makes sense to merge the just PR first instead of second? Using just makes it both more obvious what is going on and makes it trivial to execute locally.
There was a problem hiding this comment.
Fixed the issues with #1345 (command naming and broken just invocation)
|
Closing in favor of #1345 |
The PR introducing the nix flake missed ensuring that the golang input from avalanchego reflected the update for 1.24.9. This change remedies that oversight and ensures that CI will catch it in the future.