Skip to content

chore: update ClassifiedChildren to return only what's needed #1207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: qusuyan/path-guard
Choose a base branch
from
Open

chore: update ClassifiedChildren to return only what's needed #1207

wants to merge 5 commits into from

Conversation

qusuyan
Copy link
Contributor

@qusuyan qusuyan commented Aug 13, 2025 •
edited
Loading

This is part 3 of #1137

@qusuyan
Copy link
Contributor Author

qusuyan commented Aug 15, 2025

Depends on #1205

@qusuyan qusuyan mentioned this pull request Aug 15, 2025
Open
rkuris
rkuris requested changes Aug 22, 2025
View reviewed changes
Copy link
Member

@rkuris rkuris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same testing requirement. It's just too costly to break this code now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkuris rkuris rkuris requested changes

@demosdemon demosdemon demosdemon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qusuyan @demosdemon @rkuris