feat: Firewood logs #1276
Open
feat: Firewood logs #1276
+25
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alarso16
force-pushed
the
alarso16/firewood-logs
branch
from
9369c13 to
c015ee8
Compare
JonathanOppenheimer
requested changes
Sep 24, 2025
I think the VM has the obligation to only access ChainDataDir, and this isn't a functionality change. However, I should update releases.md |
RodrigoVillar
approved these changes
Sep 25, 2025
alarso16
force-pushed
the
alarso16/firewood-logs
branch
from
fcefa6f to
3d1a0b3
Compare
JonathanOppenheimer
approved these changes
Sep 25, 2025
Signed-off-by: Austin Larson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Firewood logging currently isn't being started, so this can make debugging difficult.
Closes #1265
How this works
Adds a single call to
ffi.StartLogs, which reports any error (this can only be called once per thread successfully, so any error can just be logged).How this was tested
Existing UT
Need to be documented?
Yes
Need to update RELEASES.md?
No