feat: add initial target excess #1051
Open
+17
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceyonur
reviewed
Jul 15, 2025
| } | ||
|
|
||
| var state acp176.State | ||
| var state acp176.State = acp176.State{TargetExcess: InitialTargetExcess} |
There was a problem hiding this comment.
this won't result in the desired effect if you also set desiredTargetExcess (even if it does we should not use it like that). We should set MaxTargetExcessDiff to a higher value (or disable smoothing here)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
For load-testing the C-Chain, we modify the chain's gas-per-second via the
GasTargetconfig field. However, going fromMinTargetPerSecondtoGasTargetrequires a non-negligible ramp-up period, which isn't ideal if we're running load tests on expensive hardware. This ramp-up period is a result of the target gas excess going from0to the desired target excess, which is regulated byMaxTargetExcessDiff.How this works
This PR extends the Coreth config by adding a
InitialTargetExcessfield. This field is applied to the first block and allows clients to reduce the ramp-up period by having the target gas excess start fromInitialTargetExcessinstead of0.How this was tested
Ran load test with
InitialTargetExcessandGasTargetset to desired values.Need to be documented?
Yes
Need to update RELEASES.md?
Yes