-
Notifications
You must be signed in to change notification settings - Fork 13
CP-12309 - Account overview page #3357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| ]) | ||
|
|
||
| const renderWalletIcon = useCallback((): JSX.Element => { | ||
| if (walletIcon === 'ledger') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice touch here, love this
| import { selectIsPrivacyModeEnabled } from 'store/settings/securityPrivacy' | ||
|
|
||
| export const WalletBalance = ({ | ||
| // wallet, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we remove this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need this to display the new wallet balance implementation
| balanceSx, | ||
| variant = 'spinner' | ||
| }: { | ||
| // wallet: Wallet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's for integrating the new wallet balance request
| const isBalanceAccurate = true | ||
| const isLoadingBalance = false | ||
| const refetchBalance = useCallback(() => { | ||
| // dispatch(refetchBalanceForAccount(account.id)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason to keep this commented out? is it related to the Todo above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, it's for integrating the new wallet balance request
| const { formatCurrency } = useFormatCurrency() | ||
|
|
||
| // TODO: get wallet balance | ||
| const walletBalance = 74235 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
guess we dont want to keep these hardcoded values in?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, iit's for integrating the new wallet balance request
| balanceSx={{ | ||
| color: isActive ? colors.$textPrimary : colors.$textSecondary | ||
| }} | ||
| // wallet={wallet} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feel like we should pass the wallet in here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's for the wallet balance integration
|
Also added reused useRecentAccounts to sort the accounts based off latest accessed account Simulator.Screen.Recording.-.26.-.2025-11-24.at.23.02.42.mov |
|
Added accordion animation Simulator.Screen.Recording.-.26.-.2025-11-25.at.19.37.32.mov |
|
new dev builds |
Description
Ticket: CP-12309
Ticket: CP-12312
Please provide:
Wallet overview screen
BalanceHeaderon Portfolio to show the wallet name above the balanceScreenshots/Videos
Simulator.Screen.Recording.-.26.-.2025-11-24.at.18.02.08.mov
Screen_recording_20251124_190505.webm
Testing
Dev Testing (if applicable)
iOS - 6639
Android - 6640
Single Wallet
Multiple wallets
QA Testing (if applicable)
Checklist
Please check all that apply (if applicable)