Remove GetAddressTxs #3872
Merged
Remove GetAddressTxs #3872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
joshua-kim
requested review from
meaghanfitzgerald and
StephenButtolph
as code owners
Signed-off-by: Joshua Kim <[email protected]>
|
Could you add the release notes shell to |
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
Added 5e55d87 |
Signed-off-by: Joshua Kim <[email protected]>
Co-authored-by: Stephen Buttolph <[email protected]> Signed-off-by: Joshua Kim <[email protected]>
joshua-kim
force-pushed
the
remove-get-address-txs
branch
from
165b03d to
cf09730
Compare
Signed-off-by: Joshua Kim <[email protected]>
joshua-kim
force-pushed
the
remove-get-address-txs
branch
from
cf09730 to
a49bf75
Compare
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
joshua-kim
force-pushed
the
remove-get-address-txs
branch
from
fb4eb39 to
70407c5
Compare
Signed-off-by: Joshua Kim <[email protected]>
StephenButtolph
approved these changes
Apr 10, 2025
|
since we are getting rid of the AddressTxsIndexer, does it make sense to also delete the data? |
It makes sense. I considered doing it as part of this PR but this feature/its apis have been deprecated for 2 years now + we're not aware of anyone using it (we confirmed with Binance/our internal teams, and the indexer defaults to being disabled). IMO it's not worth the effort. |
rrazvan1
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Removes deprecated api to minimize amount of state required for #3732. We have confirmed that there are no downstream users of this api.
How this works
Removes GetAddressTxs + avm tx indexer code.
How this was tested
CI
Need to be documented in RELEASES.md?
Yes