Remove support for AVM tx checksums #3774
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-kim
changed the title
joshua-kim
added
good first issue
joshua-kim
force-pushed
the
x-chain-remove-tx-checksum
branch
3 times, most recently
from
e94ca20 to
d8a0bbf
Compare
joshua-kim
force-pushed
the
x-chain-remove-tx-checksum
branch
3 times, most recently
from
319c91b to
4466d91
Compare
joshua-kim
commented
Mar 6, 2025
| @@ -110,7 +110,7 @@ func (a *acceptor) ApricotAtomicBlock(b *block.ApricotAtomicBlock) error { | |||
| zap.Stringer("blkID", blkID), | |||
| zap.Uint64("height", b.Height()), | |||
| zap.Stringer("parentID", b.Parent()), | |||
| zap.Stringer("utxoChecksum", a.state.Checksum()), | |||
There was a problem hiding this comment.
The files in platformvm feel like an unrelated change... so I can take them out if requested. The rationale for coupling them in this PR was to keep the logging consistent.
joshua-kim
force-pushed
the
x-chain-remove-tx-checksum
branch
from
4466d91 to
b021db1
Compare
Signed-off-by: Joshua Kim <[email protected]>
joshua-kim
force-pushed
the
x-chain-remove-tx-checksum
branch
from
b021db1 to
f2a6499
Compare
This comment was marked as spam.
This comment was marked as spam.
maru-ava
approved these changes
Mar 8, 2025
StephenButtolph
approved these changes
Mar 10, 2025
github-project-automation
bot
moved this from In Progress 🏗
to In Review 👀
in avalanchego
Co-authored-by: Stephen Buttolph <[email protected]> Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
cam-schultz
pushed a commit
that referenced
this pull request
Mar 24, 2025
Signed-off-by: Joshua Kim <[email protected]> Co-authored-by: Stephen Buttolph <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Once we merge #3732, checksums will be updated to be return the merkle root instead. We have to make a decision to either continue to maintain the current tx checksumming, or store our txs in a merkle trie. The only current use-case of the tx checksum is for debugging/logging purposes, so this PR removes support for it entirely.
How this works
Removes support for tx checksumming
How this was tested
CI
Need to be documented in RELEASES.md?
Yes