Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2503 doc autogen #2539

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

2503 doc autogen #2539

wants to merge 20 commits into from

Conversation

owenwahlgren
Copy link

Why this should be merged

Autogenerate markdown for CLI cmds that can be remotely fetched

How this works

Github action on PR to main with python script that generates markdown

@owenwahlgren owenwahlgren requested a review from a team as a code owner January 8, 2025 22:46
@owenwahlgren owenwahlgren linked an issue Jan 8, 2025 that may be closed by this pull request
@owenwahlgren owenwahlgren added the DO NOT MERGE This PR is not meant to be merged in its current state label Jan 8, 2025
@owenwahlgren owenwahlgren removed the DO NOT MERGE This PR is not meant to be merged in its current state label Jan 8, 2025
@meaghanfitzgerald
Copy link
Collaborator

What is the output path of the doc? The generated doc will then be referenced in docs at: https://docs.avax.network/tooling/avalanche-cli , right?

@owenwahlgren
Copy link
Author

What is the output path of the doc? The generated doc will then be referenced in docs at: https://docs.avax.network/tooling/avalanche-cli , right?

output of the .md file is in root of this project /
This will be remote referenced at https://docs.avax.network/tooling/avalanche-cli yes

@meaghanfitzgerald
Copy link
Collaborator

output of the .md file is in root of this project /

please output the file in the cmd folder, named commands.md

Ideally we will also autogen the SDK docs which would ideally live in sdk folder.

cmd/commands.md Outdated
Comment on lines 152 to 157
-l, --local operate on a local network
-m, --mainnet operate on mainnet
--node-endpoint string gather node id/bls from publicly available avalanchego apis on the given endpoint
--node-id string node-id of the validator to add
--output-tx-path string (for Subnets, not L1s) file path of the add validator tx
--partial-sync set primary network partial sync for new validators (default true)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the flags are being generated without a type, causing the description to split (see original line 152)

Suggested change
-l, --local operate on a local network
-m, --mainnet operate on mainnet
--node-endpoint string gather node id/bls from publicly available avalanchego apis on the given endpoint
--node-id string node-id of the validator to add
--output-tx-path string (for Subnets, not L1s) file path of the add validator tx
--partial-sync set primary network partial sync for new validators (default true)
-l, --local none operate on a local network
-m, --mainnet none operate on mainnet
--node-endpoint string gather node id/bls from publicly available avalanchego apis on the given endpoint
--node-id string node-id of the validator to add
--output-tx-path string (for Subnets, not L1s) file path of the add validator tx
--partial-sync none set primary network partial sync for new validators (default true)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this due to the script or the CLI command code? This happens consistently throughout the generated commands doc

@meaghanfitzgerald meaghanfitzgerald added this to the Documentation milestone Jan 13, 2025
@meaghanfitzgerald
Copy link
Collaborator

closes #2503

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review 👀
Development

Successfully merging this pull request may close these issues.

Doc Autogen
3 participants