Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix some function names in comment #2505

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cuiweiyuan
Copy link

Why this should be merged

fix some function names in comment

How this works

How this was tested

How is this documented

@cuiweiyuan
Copy link
Author

Thanks

@cuiweiyuan
Copy link
Author

Anything need I to do?

@felipemadero
Copy link
Collaborator

felipemadero commented Jan 14, 2025

Anything need I to do?

Hi. Thanks for this! Could you please sign all the commits? We need this for all PRs

@cuiweiyuan cuiweiyuan force-pushed the main branch 3 times, most recently from 3808aaa to fee3c03 Compare January 15, 2025 14:54
@cuiweiyuan
Copy link
Author

Anything need I to do?

Hi. Thanks for this! Could you please sign all the commits? We need this for all PRs

Of course.

Signed and rebased. Please review again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review 👀
Development

Successfully merging this pull request may close these issues.

2 participants