Publish workflow improvement and next example improvements #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
I feel like I am missing context here. The changes don't seem to align with the description. |
marc-aurele-besner
changed the title
Yeah I did fix/improves a few things in the next js example also in the same pr 🤦♂️ |
jfrank-summit
previously approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Publish workflow improvement and next example improvements
The main reason the workflow was failing was
.yarn/install-state.gzwill change despite been in .gitignoreI deleted the file and now it seems to not been tracked anymore...
But when reproducing the step
yarn publishstill require a human interaction to chose the versioning, so we will need to default to a set versioning bump if we want the publishing flow automated.Also a few improvement in the next js example