Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Registry & its registration example #47

Merged
merged 14 commits into from
Jul 11, 2024
Merged

Add Registry & its registration example #47

merged 14 commits into from
Jul 11, 2024

Conversation

abhi3700
Copy link
Contributor

This PR resolves #17

abhi3700 added 5 commits June 20, 2024 13:23
- Serialization error
- Increased signature algorithm bytes len from 6 bytes to 9 bytes
- TODO: Increase to at least 13 bytes
…issue-17

# Conflicts:
#	packages/auto-id/src/utils.ts
@abhi3700 abhi3700 added enhancement New feature or request auto-id Anything related to Auto-ID labels Jun 27, 2024
@abhi3700 abhi3700 self-assigned this Jun 27, 2024
Copy link
Member

@marc-aurele-besner marc-aurele-besner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few comments

packages/auto-id/src/utils.ts Outdated Show resolved Hide resolved
packages/auto-id/examples/registerAutoId.ts Outdated Show resolved Hide resolved
@abhi3700 abhi3700 requested review from marc-aurele-besner and removed request for jfrank-summit and marc-aurele-besner July 3, 2024 12:44
Copy link
Member

@jfrank-summit jfrank-summit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments.

packages/auto-id/src/utils.ts Outdated Show resolved Hide resolved
packages/auto-id/src/utils.ts Outdated Show resolved Hide resolved
abhi3700 added 3 commits July 9, 2024 11:25
Used library code instead of manual code
…issue-17

# Conflicts:
#	.yarn/install-state.gz
#	packages/auto-id/package.json
Copy link
Member

@marc-aurele-besner marc-aurele-besner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just trigger the action that had failed again and this time it worked...

@abhi3700 abhi3700 requested a review from jfrank-summit July 10, 2024 09:41
@abhi3700 abhi3700 merged commit 549fef8 into main Jul 11, 2024
2 checks passed
@abhi3700 abhi3700 deleted the fix-issue-17 branch July 11, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-id Anything related to Auto-ID enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Registry into auto-id
3 participants