Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "CertificateManager" class along with tests #28

Merged
merged 8 commits into from
Jun 21, 2024

Conversation

abhi3700
Copy link
Contributor

This PR adds CertificateManager class and its tests & resolves #16.

The main functions are:

  • prettyPrintCertificate
  • createCSR
  • signCSR
  • createAndSignCSR
  • issueCertificate
  • selfIssueCertificate
  • saveCertificate

@abhi3700 abhi3700 added enhancement New feature or request auto-id Anything related to Auto-ID labels Jun 18, 2024
@abhi3700 abhi3700 self-assigned this Jun 18, 2024
Copy link
Member

@marc-aurele-besner marc-aurele-besner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment regarding the direct use of fs 👇

Copy link
Member

@marc-aurele-besner marc-aurele-besner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@abhi3700 abhi3700 changed the title Fix issue 16 peculiar x509 Add "CertificateManager" class along with tests Jun 19, 2024
Copy link
Member

@jfrank-summit jfrank-summit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments.

packages/auto-id/src/certificateManager.ts Outdated Show resolved Hide resolved
packages/auto-id/src/certificateManager.ts Outdated Show resolved Hide resolved
@abhi3700 abhi3700 merged commit 0578bd5 into main Jun 21, 2024
2 checks passed
@abhi3700 abhi3700 deleted the fix-issue-16-peculiar-x509 branch June 24, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-id Anything related to Auto-ID enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add certificate manager module in auto-id package
3 participants