Skip to content

Remove Piccadilly Testnet - Piccadilly decommissioning scheduled for 2025-09-26#278

Merged
cmjc merged 3 commits intomasterfrom
piccadilly-network
Sep 26, 2025
Merged

Remove Piccadilly Testnet - Piccadilly decommissioning scheduled for 2025-09-26#278
cmjc merged 3 commits intomasterfrom
piccadilly-network

Conversation

@cmjc
Copy link
Collaborator

@cmjc cmjc commented Sep 25, 2025

PR to make edits for the Piccadilly Testnet decommissioning, which is scheduled for 2025-09-26.

Full list of edits in #276

closes #253 and closes #276

@github-actions
Copy link

github-actions bot commented Sep 25, 2025

🚀 This branch can be previewed at https://67ee0c6d.docs-autonity-org.pages.dev

Copy link
Collaborator

@aiman aiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still references to Piccadilly remaining in several documents

@cmjc
Copy link
Collaborator Author

cmjc commented Sep 25, 2025

Hi @aiman - I left the Piccadilly mentions in the command-line reference as:

  • the flag command-line option is still in the client, the config isn't. Anyone using it in error cannot connect to Piccadilly
  • to keep the command-line reference in sync with the AGC command-line output which has the flag.

However, now removed in commit 6bb711e

Copy link
Collaborator

@aiman aiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you run a scan of the repo, there are still references to Piccadilly. Please remove them or advise why they are retained.

@cmjc
Copy link
Collaborator Author

cmjc commented Sep 26, 2025

If you run a scan of the repo, there are still references to Piccadilly. Please remove them or advise why they are retained.

% grep -lr "piccadilly" .
./.devenv/state/venv/lib/python3.11/site-packages/eth_utils/__json/eth_networks.json
./developer/deploy-truffle/index.md
./docs/developer/deploy-truffle/index.html
./docs/networks/mainnet/dax.html
./docs/account-holders/setup-nodejsconsole/index.html
./docs/reference/utility-tools/index.html
./networks/mainnet/dax.md
./.git/config
./.git/HEAD
./.git/logs/HEAD
./.git/logs/refs/heads/piccadilly-network
./.git/COMMIT_EDITMSG
./account-holders/setup-nodejsconsole/index.md
./.quarto/xref/6d09eb29
./.quarto/xref/55d4e291
./.quarto/xref/INDEX
./.quarto/idx/developer/deploy-truffle/index.md.json
./.quarto/idx/networks/mainnet/dax.md.json
./.quarto/idx/account-holders/setup-nodejsconsole/index.md.json
./.quarto/idx/reference/utility-tools/index.md.json
./reference/utility-tools/index.md

These are all in non-published/live page content, hence no edits.

I will go through them now and cleanse.

@cmjc
Copy link
Collaborator Author

cmjc commented Sep 26, 2025

Hi @aiman cleansed in commit 6d22937.


I have been through and:

./networks/mainnet/dax.md
./docs/networks/mainnet/dax.html

Changed to Bakerloo. A WIP draft pending AMM.

./developer/deploy-truffle/index.md
./docs/developer/deploy-truffle/index.html
./docs/account-holders/setup-nodejsconsole/index.html
./account-holders/setup-nodejsconsole/index.md
./docs/reference/utility-tools/index.html
./reference/utility-tools/index.md

Removed: legacy, hidden pages. Also removed the legacy submit-trans-nodejsconsole and make-calls-nodejsconsole. Overdue legacy cleanup.

This leaves:

% grep -lr "piccadilly" .
./.devenv/state/venv/lib/python3.11/site-packages/eth_utils/__json/eth_networks.json
./.git/config
./.git/HEAD
./.git/logs/HEAD
./.git/logs/refs/heads/piccadilly-network
./.git/COMMIT_EDITMSG
./.quarto/xref/6d09eb29
./.quarto/xref/55d4e291
./.quarto/xref/INDEX

The python3.11/site-packages/eth_utils has all the historical listed Bakerloo and Piccadilly networks in it.

The git and quarto are because the branch is named piccadilly-network and because of piccadilly appearing in what are now old quarto xref files.

@aiman
Copy link
Collaborator

aiman commented Sep 26, 2025

You can use git grep to ignore untracked files: git grep -i piccadilly.

@cmjc cmjc requested a review from aiman September 26, 2025 10:49
Copy link
Collaborator

@aiman aiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmjc cmjc merged commit 150d252 into master Sep 26, 2025
3 checks passed
@cmjc cmjc deleted the piccadilly-network branch September 26, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Edits for decommissioning of Piccadilly Testnet Update testnet pages and references - Networks, Guides, Reference

2 participants