Support signing legacy transactions with Trezor #208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original motivation for keeping type checking in the default environment is so that it can be executed from the `github` and `local` environments. Otherwise, it would not be possible to run type checks in those environments against the correct version of autonity.py. This restores `check-types` to the default environment, partially reverting the change in e74d922. This would be how to run type checks in the `github` environment: ``` hatch env prune export AUTPY_GIT_COMMIT=... hatch env create github hatch -e github run pip freeze | grep autonity # verify correct hatch run github:check-types ```
The `tx make --legacy` option does not do what it says, because `tx make` adds `maxFeePerGas` and `maxPriorityFeePerGas` to the transaction params, negating the option, and forcing it to become a TransactionType 0x2 instead. In order to force a LegacyTransaction as per EIP-2718, set the `--gas-price` instead, which matches the logic used and expected by web3.py itself.
aiman
force-pushed
the
trezor-legacy-transactions
branch
from
03bf33c to
e456ce7
Compare
szemate
approved these changes
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main change is support for signing legacy type 0x0 transactions.