Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to opentelemetry 0.24 #179

Merged
merged 9 commits into from
Jul 25, 2024
Merged

update to opentelemetry 0.24 #179

merged 9 commits into from
Jul 25, 2024

Conversation

mellowagain
Copy link
Member

fixes #177

Checklist

  • Changelog updated

@mellowagain
Copy link
Member Author

tracing-opentelemetry is only on otel 0.23, theres currently a pr open to update it to 0.24: tokio-rs/tracing-opentelemetry#155

once that one is merged and released we can continue with the otel 0.24 upgrade. im pausing this pr for now

@xmakro
Copy link

xmakro commented Jul 21, 2024

tracing-opentelemtry was updated to 0.25:
tokio-rs/tracing-opentelemetry#156

@mellowagain
Copy link
Member Author

mellowagain commented Jul 23, 2024

ran into another blocker which seems not that easily solveable, the prometheus-exporter feature depends on opentelemetry_prometheus, which is not updated to the new opentelemetry version and there doesn't even seem to be a plan to do so. on the readme of the project it states

The development of prometheus exporter has halt until the Opentelemetry metrics API and SDK reaches 1.0. Current implementation is based on Opentelemetry API and SDK 0.23.

others people also running into this: open-telemetry/opentelemetry-rust#1950

seems like this will be hard block for a while until opentelemetry reaches 1.0. im not sure if that is going to happen anytime soon, i thought it was blocked until there was consensus on open-telemetry/opentelemetry-rust#1571 but that may be wrong.

we can optionally choose to fork and update opentelemetry_prometheus ourselves but that is additional maintenance burden and wouldn't play well if a user of autometrics includes the opentelemetry_prometheus themselves, as there would be conflicting versions then.

@xmakro
Copy link

xmakro commented Jul 24, 2024

opentelemetry_prometheus 0.17 was released 🎉

CHANGELOG.md Outdated Show resolved Hide resolved
examples/opentelemetry-push-custom/Cargo.toml Outdated Show resolved Hide resolved
@mellowagain mellowagain enabled auto-merge (squash) July 25, 2024 12:58
@mellowagain mellowagain disabled auto-merge July 25, 2024 12:59
@mellowagain mellowagain merged commit 12b0569 into main Jul 25, 2024
1 check passed
@mellowagain mellowagain deleted the otel-0.24 branch July 25, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for opentelemetry 0.23.0
3 participants