Add platform_tests for installation on multiple platforms including macos, ubuntu and windows #119
Conversation
- Cap current_time at time limit using min() - Use normalized progress ratio (0-1) instead of raw time value - Fixes StreamlitAPIException when progress exceeds 100
This reverts commit a38ddf4.
There was a problem hiding this comment.
Thanks a lot @tonyhoo for adding this, overall LGTM! Left some questions in the review. Feel free to go ahead when the test run passed on your fork :)
| python -m pip install --upgrade pip | ||
| python -m pip install tox | ||
| python -m pip install flake8 | ||
| python -m pip install bandit | ||
| python -m pip install packaging | ||
| python -m pip install ruff |
There was a problem hiding this comment.
Are we using/calling all these deps somewhere?
There was a problem hiding this comment.
These settings are copied from AutoGluon. Most are for lint and security checks, which we'll need later.
There was a problem hiding this comment.
Alright I'll merge once tests passed, I'm assuming there will be a follow up PR to enable the use of those deps later. Also we already have a lint CI: https://github.com/autogluon/autogluon-assistant/blob/main/.github/workflows/lint.yml
|
@tonyhoo looks like lightgbm is causing failures on macOS platform tests https://github.com/tonyhoo/autogluon-assistant/actions/runs/11813461092/job/32910561260 |
Issue #, if available:
Description of changes:
Add platform_tests for installation on multiple platforms including macos, ubuntu and windows
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.