Update load balance policies to return vector of strings instead of a…

… single string
auto-ndp · Feb 14, 2024 · a268b3e · a268b3e
1 parent 0376aa4
commit a268b3e
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/src/loadbalance/LeastLoadAveragePolicy.cpp b/src/loadbalance/LeastLoadAveragePolicy.cpp
@@ -1,7 +1,7 @@
 #include <faabric/loadbalance/LoadBalancePolicy.h>
 #include <stdexcept>
 
-std::string LeastLoadAveragePolicy::dispatch(const std::set<std::string>& warm_faaslets, int number_of_messages, faabric::scheduler::Scheduler& scheduler)
+std::vector<std::string> LeastLoadAveragePolicy::dispatch(const std::set<std::string>& warm_faaslets, int number_of_messages, faabric::scheduler::Scheduler& scheduler)
 {
     throw std::runtime_error("LeastLoadAveragePolicy::dispatch not implemented");
 }
diff --git a/src/loadbalance/MostSlotsPolicy.cpp b/src/loadbalance/MostSlotsPolicy.cpp
@@ -1,7 +1,7 @@
 #include <faabric/loadbalance/LoadBalancePolicy.h>
 #include <stdexcept>
 
-std::string MostSlotsPolicy::dispatch(const std::set<std::string>& warm_faaslets, int number_of_messages, faabric::scheduler::Scheduler& scheduler)
+std::vector<std::string> MostSlotsPolicy::dispatch(const std::set<std::string>& warm_faaslets, int number_of_messages, faabric::scheduler::Scheduler& scheduler)
 {
     throw std::runtime_error("MostSlotsPolicy::dispatch not implemented");
 }
diff --git a/src/scheduler/Scheduler.cpp b/src/scheduler/Scheduler.cpp
@@ -554,7 +554,7 @@ faabric::util::SchedulingDecision Scheduler::doSchedulingDecision(
 
             FaasmDefaultPolicy policy;
             const std::set<std::string>& thisRegisteredHosts = getFunctionRegisteredHosts(firstMsg.user(), firstMsg.function(), false);
-            std::vector<std::string> balanced_order = policy.dispatch(thisRegisteredHosts, remainder);
+            std::vector<std::string> balanced_order = policy.dispatch(thisRegisteredHosts, remainder, this); // Messy DI to get access to methods
 
             remainder -= balanced_order.size();
             for (const auto& h : balanced_order) {