Add BOOST_NO_TYPEID=1 to the conan build environment to prevent crash…

…es. (faasm#278) * Add BOOST_NO_TYPEID=1 to the conan build environment to prevent crashes. Cpprestsdk uses boost::asio itself, which caused conflicting definitions to be linked together, leading to the version with RTTI enabled taking precedence during linktime. * Re-enable RTTI * revert errors when merging * endpoint: fix compilation warning Co-authored-by: Carlos Segarra <[email protected]>
auto-ndp · Oct 26, 2022 · 3d17b93 · 3d17b93
1 parent dbaf5a2
commit 3d17b93
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/cmake/ExternalProjects.cmake b/cmake/ExternalProjects.cmake
@@ -142,6 +142,5 @@ target_link_libraries(faabric_common_dependencies INTERFACE
 )
 target_compile_definitions(faabric_common_dependencies INTERFACE
     FMT_DEPRECATED= # Suppress warnings about use of deprecated api by spdlog
-    BOOST_NO_TYPEID=1 # Prevent odd crashes within asio implementation
 )
 add_library(faabric::common_dependencies ALIAS faabric_common_dependencies)
diff --git a/include/faabric/endpoint/FaabricEndpoint.h b/include/faabric/endpoint/FaabricEndpoint.h
@@ -16,7 +16,7 @@ enum class EndpointMode
 };
 
 namespace detail {
-struct EndpointState;
+class EndpointState;
 }
 
 struct HttpRequestContext