Fix for Rust 2018 RC1#31
Merged
KodrAus merged 4 commits intoauto-impl-rs:masterfrom Sep 22, 2018
LukasKalbertodt:fix-for-2018-rc1
Merged
Fix for Rust 2018 RC1#31KodrAus merged 4 commits intoauto-impl-rs:masterfrom LukasKalbertodt:fix-for-2018-rc1
KodrAus merged 4 commits intoauto-impl-rs:masterfrom
LukasKalbertodt:fix-for-2018-rc1
Conversation
Member
Author
|
I asked/opened a bug report now: rust-lang/rust#54418. Let's see what this results in. |
See this for more information: rust-lang/rust#54418
Member
Author
|
I thought about adding testing with beta to |
7 tasks
KodrAus
reviewed
Sep 22, 2018
| #[cfg(feature = "nightly")] | ||
| fn param_span() -> Span2 { | ||
| ::proc_macro::Span::def_site().into() | ||
| crate::proc_macro::Span::def_site().into() |
Member
There was a problem hiding this comment.
Ah, I think I've hit this same issue in recent 2018 previews with the test crate.
KodrAus
approved these changes
Sep 22, 2018
Member
KodrAus
left a comment
KodrAus
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks @LukasKalbertodt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I started to fix some things to get this crate building with the new RC1 that was just released.
EDIT: ok, problem solved, I guess. Original comment message in edit history.