Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metrics for usage of the replication proxies in the datastore #2229

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Add metrics for usage of the replication proxies in the datastore #2229

merged 1 commit into from
Feb 3, 2025

Conversation

josephschorr
Copy link
Member

@josephschorr josephschorr commented Feb 3, 2025 •
edited
Loading

Should help provide some insights into when the read replicas are being used vs the primary

@josephschorr josephschorr requested a review from a team as a code owner February 3, 2025 15:47
@github-actions github-actions bot added the area/datastore Affects the storage system label Feb 3, 2025
bison
bison reviewed Feb 3, 2025
View reviewed changes
Copy link
Member

@bison bison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have some kind of name or stable ID for a replica? If there are multiple, can we label the counters with it?

@josephschorr
Copy link
Member Author

Do we have some kind of name or stable ID for a replica? If there are multiple, can we label the counters with it?

Currently, no. We'd have to extract it from the URI or the "position"; we could label them replica_0, replica_1, or we could try to pull some info from the connection URI

@josephschorr josephschorr added this pull request to the merge queue Feb 3, 2025
Merged via the queue into authzed:main with commit abdc17d Feb 3, 2025
39 checks passed
@josephschorr josephschorr deleted the replication-metrics branch February 3, 2025 16:35
@github-actions github-actions bot locked and limited conversation to collaborators Feb 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bison bison bison left review comments

@vroldanbet vroldanbet vroldanbet approved these changes

Assignees
No one assigned
Labels
area/datastore Affects the storage system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@josephschorr @bison @vroldanbet