Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default version for CRDB testing to latest #2226

Merged
merged 2 commits into from
Feb 4, 2025
Merged

Change default version for CRDB testing to latest #2226

merged 2 commits into from
Feb 4, 2025

Conversation

josephschorr
Copy link
Member

Also adds ability to test at different versions

@josephschorr
Change default version for CRDB testing to latest
be575b1 
Also adds ability to test at different versions
@github-actions github-actions bot added area/datastore Affects the storage system area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) labels Feb 2, 2025
vroldanbet
vroldanbet reviewed Feb 3, 2025
View reviewed changes
Copy link
Contributor

@vroldanbet vroldanbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes LGTM, do we want to also add a new GHA matrix to test with multiple CRDB versions in CI?

@josephschorr
Copy link
Member Author

do we want to also add a new GHA matrix to test with multiple CRDB versions in CI?

Yeah, I was going to do that as a followup

@josephschorr josephschorr marked this pull request as ready for review February 3, 2025 22:04
@josephschorr josephschorr requested a review from a team as a code owner February 3, 2025 22:04
@josephschorr josephschorr added this pull request to the merge queue Feb 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 4, 2025
@josephschorr josephschorr added this pull request to the merge queue Feb 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 4, 2025
@vroldanbet vroldanbet added this pull request to the merge queue Feb 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 4, 2025
@josephschorr josephschorr added this pull request to the merge queue Feb 4, 2025
Merged via the queue into authzed:main with commit abdb041 Feb 4, 2025
39 checks passed
@josephschorr josephschorr deleted the crdb-test-version branch February 4, 2025 20:10
@github-actions github-actions bot locked and limited conversation to collaborators Feb 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vroldanbet vroldanbet vroldanbet approved these changes

Assignees
No one assigned
Labels
area/datastore Affects the storage system area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josephschorr @vroldanbet