fixes datastore command not using the spicedb prefix for ENV
#1682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the datastore command didn't correctly wire up the program name, which is `spicedb`. This is used to determine the prefix of environment variables. As a consequence, the datastore command won't recognize environment variables like `SPICEDB_<CONFIG_OPTION>` but instead expects `DATASTORE_<CONFIG_OPTION>`.
vroldanbet
changed the title
spicedb prefixspicedb prefix for ENV
jzelinskie
approved these changes
Dec 12, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the datastore command didn't correctly wire up the program name, which is
spicedb. This is usedto determine the prefix of environment variables.
As a consequence, the datastore command won't recognize environment variables like
SPICEDB_<CONFIG_OPTION>but instead expectsDATASTORE_<CONFIG_OPTION>.