Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky Postgres GC tests #1655

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

josephschorr
Copy link
Member

@josephschorr josephschorr commented Nov 16, 2023

Ensures that all Postgres GC tests run against their own PG instance

This is necessary because the GC tests check transaction IDs and those can change out from underneath the tests due to other tests performing work

@github-actions github-actions bot added area/datastore Affects the storage system area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) labels Nov 16, 2023
@josephschorr josephschorr force-pushed the postgres-gc-test-window branch from 6456626 to 9f459c7 Compare November 16, 2023 22:17
@josephschorr josephschorr changed the title Make the Postgres GC window as small as possible in the GC tests WIP: Fix flaky Postgres GC tests Nov 16, 2023
@josephschorr josephschorr force-pushed the postgres-gc-test-window branch 2 times, most recently from a747873 to beb6d4d Compare November 20, 2023 16:06
@josephschorr josephschorr force-pushed the postgres-gc-test-window branch from beb6d4d to 0d0cfac Compare December 1, 2023 18:45
@josephschorr josephschorr force-pushed the postgres-gc-test-window branch from 0d0cfac to 70b9d94 Compare January 29, 2024 17:21
@josephschorr josephschorr force-pushed the postgres-gc-test-window branch from 70b9d94 to 450b1f7 Compare January 30, 2024 17:13
@josephschorr josephschorr changed the title WIP: Fix flaky Postgres GC tests Fix flaky Postgres GC tests Jan 30, 2024
@josephschorr josephschorr marked this pull request as ready for review January 30, 2024 17:25
@josephschorr josephschorr requested a review from a team January 30, 2024 17:25
@vroldanbet vroldanbet added this pull request to the merge queue Jan 30, 2024
Merged via the queue into authzed:main with commit 04c7255 Jan 30, 2024
20 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/datastore Affects the storage system area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants