Skip to content

Error in running the zerocode tests in JDK23/21 #704 #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

rkampani
Copy link
Collaborator

Fixes Issue

  • Which issue or ticket was(will be) fixed by this PR? (capture the issue number)

PR Branch
#ADD LINK TO THE PR BRANCH

Motivation and Context

Checklist:

  • New Unit tests were added

    • Covered in existing Unit tests
  • Integration tests were added

    • Covered in existing Integration tests
  • Test names are meaningful

  • Feature manually tested and outcome is successful

  • PR doesn't break any of the earlier features for end users

    • WARNING! This might break one or more earlier earlier features, hence left a comment tagging all reviewrs
  • Branch build passed in CI

  • No 'package.*' in the imports

  • Relevant DOcumentation page added or updated with clear instructions and examples for the end user

    • Not applicable. This was only a code refactor change, no functional or behaviourial changes were introduced
  • Http test added to http-testing module(if applicable) ?

    • Not applicable. The changes did not affect HTTP automation flow
  • Kafka test added to kafka-testing module(if applicable) ?

    • Not applicable. The changes did not affect Kafka automation flow

@authorjapps
Copy link
Owner

Hello Both @rkampani and @thanasissot,
you have been added as a collaborator now. You can join by accepting the invitation here.

This should allow you the trigger builds, review/approve other's PRs etc much more things. 👍

@rkampani rkampani force-pushed the feature/704-fixJunitsJdk24 branch from dd30856 to e6d901c Compare May 1, 2025 01:44
rkampani added 4 commits May 1, 2025 09:23
remove jukitoJar with Junit5 and Guice

remove jukitoJar with Junit5 and Guice

remove jukitoJar with Junit5 and Guice
@rkampani
Copy link
Collaborator Author

rkampani commented May 3, 2025

@authorjapps : Here are changes that are addressed in the PR

  • JDK Compatibility: Tests run successfully with reports generated correctly. Minor tweaks were made to prevent test and build failures. However, JDK 9+ (JPMS) imposes stricter module boundaries, affecting reflection and class accessibility. Fully moving to higher JDKs will require updating or replacing legacy Reflection code for compatibility
  • Jukito to Guice: Swapped Jukito for Guice to ensure compatibility with newer JDKs and ease future upgrades.
  • Type Reference Fixes: Adjusted methods to handle stricter type enforcement in newer JDKs, preventing errors.
  • Gson Optional Support: Added a custom TypeAdapter for java.util.Optional to enable proper JSON serialization/deserialization.

if you notice anything that doesn't quite align with the requirements or could potentially introduce issues, please feel free to suggest improvements. If needed, or we can also consider closing it. and If there’s anything I’ve missed or any changes that might lead to issues, I’d really appreciate your feedback and suggestions.

@rkampani rkampani marked this pull request as ready for review May 3, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants